Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding alternate row shading for readability. #124

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Adding alternate row shading for readability. #124

merged 1 commit into from
Dec 30, 2024

Conversation

Mohit-Agarwa1
Copy link
Contributor

#122

Needs documentation, etc. accommodations, but provides the feature with the option to turn it on and adjust the color in moprc.

@brandleesee
Copy link
Collaborator

Thank you, @Mohit-Agarwa1.
Can you return with a screenshot of the terminal?
My intention is to see how it looks with the stock options.

@Mohit-Agarwa1
Copy link
Contributor Author

Apologies for a very late reply. Looks like this.
Screen Shot 2024-12-30 at 00 55 53

@Mohit-Agarwa1
Copy link
Contributor Author

The RowShading color can be configured in ~/.moprcfor users with different color schemes which might not work with the default setup. This is also where RowShading is enabled.

@brandleesee
Copy link
Collaborator

Cheers, Mohit! No problem. Thank you for the screenshot. May I suggest a grey colour rather than that aggressive white? If you agree, please change it. If not I will merge as it is now.

@Mohit-Agarwa1
Copy link
Contributor Author

It should be lightgray rather than white — simply my iTerm profile which produces the color shown, darkgray unfortunately doesn’t give the right contrast.

@brandleesee
Copy link
Collaborator

I understand, thank you.
Merged.
Thank you for your contributions.
Looking forward for more ;)

@brandleesee brandleesee merged commit c8e3bea into mop-tracker:master Dec 30, 2024
@Mohit-Agarwa1 Mohit-Agarwa1 mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mohit-Agarwa1 @brandleesee